Switch the type of the Task priority to FwTaskPriorityType#3617
Switch the type of the Task priority to FwTaskPriorityType#3617LeStarch merged 6 commits intonasa:develfrom
Conversation
| LinuxGpioDriver ::LinuxGpioDriver(const char* const compName) : LinuxGpioDriverComponentBase(compName) {} | ||
|
|
||
| Drv::GpioStatus LinuxGpioDriver ::start(const FwSizeType priority, | ||
| Drv::GpioStatus LinuxGpioDriver ::start(const FwTaskPriorityType priority, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| #endif | ||
|
|
||
| void ActiveComponentBase::start(Os::Task::ParamType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity, Os::Task::ParamType identifier) { | ||
| void ActiveComponentBase::start(FwTaskPriorityType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity, Os::Task::ParamType identifier) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
|
Also opened PR for FPP: nasa/fpp#711 |
kevin-f-ortega
left a comment
There was a problem hiding this comment.
This looks good to me. Nice work!
NOTE: This PR depends on nasa/fpp#711
|
What is the process for getting this PR merged? Do you need an alpha release from FPP? It looks like CI is passing as is. nasa/fpp#711 looks good to me, but if I merge it to nasa/fpp/main, then nasa/fpp/main will be broken against nasa/fprime/devel until this PR is merged. Can we merge this PR first? |
|
Since CI passes, I am ok to merge here if that makes FPP easier. |
|
It does make it easier in this case, since merging to F Prime first does not break fprime/devel, but merging to FPP first breaks fpp/main. In the future, in a case where a PR to fpp/main would cause a breakage against fprime/devel, and a simultaneous PR to fprime/devel needs an alpha release with the changes to FPP, I' d like to make the alpha release off of a release branch, instead of fpp/main. I'd like to avoid merging PRs that cause fpp/main to break when paired with fprime/devel. If you want, I can use this process for this PR (make a release branch of FPP, make an alpha release, update and merge this PR, merge the release branch to fpp/main) but it seems unnecessary in this case. |
|
Alternatively: We have another PR open against FPP that is paired with changes to F Prime. See nasa/fpp#716. We could consolidate that one and this one into an FPP alpha release. |
Change Description
Updated OSAL to use (already defined) FwTaskPriorityType and created new default of TASK_PRIORITY_DEFAULT.
Note that there are also corresponding FPP updates for autocoder-generated files.
Rationale
#3410
Testing/Review Recommendations
Locally ran the below to ensure they pass:
Future Work
N/A