Skip to content

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Jul 27, 2020

Describe the contribution
Fix #118

  • Resolves commented out code warnings
  • Resolves unused packages in hand generated code

Testing performed
Sent commands and viewed telemetry

Expected behavior changes
Resolve LGTM warnings on analysis

System(s) tested on

  • Hardware: cFS Dev VM
  • OS: Ubuntu 18.04
  • Versions: current bundle

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

astrogeco and others added 6 commits May 29, 2020 18:46
- Resolves commented out code warnings
- Resolves unused packages in hand generated code
@skliper skliper added CCB:FastTrack enhancement New feature or request labels Jul 27, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2020

This pull request fixes 2 alerts when merging c377629 into 2cdf182 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@astrogeco astrogeco added IC-20200729 CCB:Approved Indicates approval by CCB labels Aug 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate August 5, 2020 02:43
@astrogeco astrogeco merged commit d6bcef6 into nasa:integration-candidate Aug 5, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request fixes 2 alerts when merging c377629 into c22f00e - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@skliper skliper added this to the 2.2.0 milestone Aug 21, 2020
@skliper skliper deleted the fix118-resolve-lgtm-issues branch February 1, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates approval by CCB CCB:FastTrack enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean a few LGTM issues

2 participants