Add support for sendCOMM method#217
Merged
jason-watkins merged 2 commits intonasa:developfrom Jun 27, 2020
sanderdatema:develop
Merged
Add support for sendCOMM method#217jason-watkins merged 2 commits intonasa:developfrom sanderdatema:develop
jason-watkins merged 2 commits intonasa:developfrom
sanderdatema:develop
Conversation
Credits go to user @angelsware, I just did a copy/paste from #120
jason-watkins
requested changes
Jun 27, 2020
Contributor
jason-watkins
left a comment
There was a problem hiding this comment.
Looks good. Just one nitpick. Could you please change all of the quotes in the Python file back to single quotes?
Contributor
Author
|
Did my editor change them again? I thought I disabled the auto formatting... Ok, just a sec. |
jason-watkins
approved these changes
Jun 27, 2020
Contributor
|
Thanks, and yes. I'm working on drafting a new release candidate now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credits go to @angelsware, I just did a copy/paste from #120