python3 integer division issue#208
Merged
jason-watkins merged 1 commit intonasa:developfrom May 28, 2020
Merged
Conversation
Contributor
|
Hi Harrison, Thanks for this fix! I don't think you've submitted a pull request before. Could you please fill out our contributor license agreement and email it to me (jason.watkins@nasa.gov)? Once we've got a CLA on file for you I'll go ahead and merge this. |
Contributor
Author
|
I've sent the agreement, thanks! |
jason-watkins
approved these changes
May 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readDATAmethod usesrangewhich requires the argument to be an integer ('float' object cannot be interpreted as an integer).rowsis calculated by dividing the length of the buffer -5 by 36. Division in python 3 returns a float. By using integer division (//instead of/), therowsvariable will be an int which will not cause this exception.