Configurable Chase Camera#188
Conversation
# Conflicts: # xpcPlugin/MessageHandlers.cpp
|
It looks like you're trying to include the C client header in one of the plugin source files... Was that intentional for some reason? Looks good otherwise. I'll do a detailed review once all of the builds are working. |
|
I am using the enum VIEW_TYPE, so to ensure consistency I included the client header. How would you propose to do it to ensure compatibility? Obviously, the enum can be copied into the plugin header, but then changes have to be applied in both locations. |
|
Ah, I see. I'd prefer not to do that for two reasons. One, I just don't like the cross dependency from a build perspective. Second, I like the plugin code to stay C++, and I hate C-style enums in C++ code. I don't think there's any real problem with copying the enum over to the plugin header (and making it an |
|
Here is the msg definition for the extended camera for the wiki: |
jason-watkins
left a comment
There was a problem hiding this comment.
Just a couple of style nitpicks. Looks ready to go as far as functionality goes.
|
this all works fine on Mac, so #75 can be closed as well. |
|
Looks good. Thanks as always for the contribution! |
This PR extends the previous runway camera contribution by adding an option to position the chase camera relative to the aircraft such that it moves with it and points at the specified direction in local aircraft axes.
This allows to quickly switch pre-programmed camera angles of the flying aircraft.
A new file was added to group the camera callbacks.