Skip to content

Terrain height probe#186

Merged
jason-watkins merged 6 commits intonasa:developfrom
flyingk:terrain_PR
Nov 6, 2019
Merged

Terrain height probe#186
jason-watkins merged 6 commits intonasa:developfrom
flyingk:terrain_PR

Conversation

@flyingk
Copy link
Copy Markdown
Contributor

@flyingk flyingk commented Nov 6, 2019

This adds the capability to obtain the terrain height above MSL at a given location using a XPLM terrain probe. A new message pair (GETT query, terrain response) was added to specify the probe location and to return the data.

The probe is persistent once created for speed. Currently only one probe is supported.

Using this mechanism allows to land an aircraft onto the x-plane world.

Definitions for the message formats will be added shortly.

@flyingk flyingk changed the base branch from master to develop November 6, 2019 10:48
@flyingk flyingk changed the title Terrain probe Terrain height probe Nov 6, 2019
@flyingk
Copy link
Copy Markdown
Contributor Author

flyingk commented Nov 6, 2019

message formats:
xplane_terrain_msg.xlsx

Copy link
Copy Markdown
Contributor

@jason-watkins jason-watkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. Just a couple of nitpicks to fix and I'll merge it.

@jason-watkins
Copy link
Copy Markdown
Contributor

jason-watkins commented Nov 6, 2019

Also, I don't suppose you have any idea why this PR seems to break the macOS build on Azure?

Edit: Looks like the other PR has the same problem, so I guess Azure is just broken for no reason. sigh

@flyingk
Copy link
Copy Markdown
Contributor Author

flyingk commented Nov 6, 2019

The error message is about not finding Mac OS SDK 10.14. Is it running on an older system/Xcode version? 10.14 is specified in that yml file. Maybe try to set it to earlier version? Builds/works fine on 10.14 for me.

@jason-watkins
Copy link
Copy Markdown
Contributor

Well, using the 10.15 SDK seems to work, but everything I can find in the Azure docs suggests that 10.14 should continue to work as well. Anyway, I think it's fixed now and I'm not aware of any downside to building the plugin against the latest SDK version.

@flyingk
Copy link
Copy Markdown
Contributor Author

flyingk commented Nov 6, 2019

Would you be able to add the message format (as provided in comment above) to the wiki? Can't send PR for that...

@jason-watkins
Copy link
Copy Markdown
Contributor

Wiki updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants