Conversation
… HandlePOSI functions
* Updated POSI to use doubles for lat/lon/alt, as step size for floats was unacceptably large at high longitudes.
…ndows plugin binaries
Adds new cases such that: 0: Unpauses all a/c 1: Pauses all a/c 2: Switches case for all a/c 100:119: Pauses a/c 0:19 200:219: Unpauses a/c 0:19 Updates log messages. Keeps the 0,1,2 arguments as they previously were.
Include "-fno-stack-protector" for linking and compiling for systems that do not have this have this flag as a default.
Previously, the code enabled the AI before setting the position of a/c, which negated its purpose.
1eccd5f to
e110520
Compare
* update ignore * basics working * set cam pos remotely * log cam position * keep default behaviour, if short view message is received Compatibility with existing software * all to tabs * rename variable * option to use camera direction fields
|
While testing this on Mac OS: If i can help you with Mac binaries let me know. |
* Added Timer * Added UDPSocket::GetAddr * Added MessageHandlers::SendBeacon() * PoC of starting a timer on PluginEnable * C++11 * Added Timer to xcode project * C++11 in cmake * added Timer to cmake * use function pointer in Timer * moved Timer to namespace + wait for thread to join when stopping the timer * Windows: changed uint to unisgned short * Windows: Added Timer.h/cpp to project * GetAddr static * Send xplane and plugin version with BECN * SendBeacon with params * fixed file copyrights * Include functional to fix Linux compile error * review fixes * Send plugin receive port in BECN * review fixes
|
Hi,
|
|
Unfortunately I don't have a timeline right now. I don't feel comfortable accepting third party binaries into the repo, but I do have an alternative solution in mind... If anyone cares to submit a PR to set up any continuous integration service/services that are free for open source projects and can be configured to produce the necessary binaries, I'll gladly take the binaries produced by that service. It's on my todo list to do this myself, but I have an unfortunate lack of bandwidth for personal projects these days, and since I don't currently have any NASA funding for XPC, any work I do on the project has to be on my own time. |
|
Hi Jason, |
|
Hi all, |
|
Yep, I think Travis would work. I actually had another project set up to use it, but unfortunately that project is no longer open source so I can't link to it as a starting point. Travis's Windows support is also pretty new, so I was actually using Tavis for Linux/Mac and Appveyor for Windows on said project. Travis would be ideal for me in the sense that I'm familiar with it so it's easy for me to review the PR. It's also convenient that it should be a one-stop-shop for all OSes we support now. That said, I left my comment above open-ended because I don't necessarily want to discourage other solutions. If I get a PR that uses another service I'm happy to review that too. |
|
I already started to work on a Travis setup. I’ll make a PR |
* Do not build for i386 on macOS Use ARCHS_STANDARD to avoid the error “The i386 architecture is deprecated. You should update your ARCHS build setting to remove the i386 architecture.” * Fixed missing include The Visual Studio solution was not compiling * Fixed isnan ambigious refernce Ambigious reference when compiling on travis https://stackoverflow.com/questions/33770374/why-is-isnan-ambiguous-and-how-to-avoid-it * Set MSVC warning level to 3 Too many warnings were generated when building a Release build making Travis job to fail because of too much output * Use default toolset for Visual Studio AppVeyor recommends to set the default toolset * #include <cstdint> * Use MSVC ToolsVersion="14.0" # Conflicts: # xpcPlugin/xpcPlugin/xpcPlugin.vcxproj * Removed binaries from repository # Conflicts: # xpcPlugin/XPlaneConnect/64/win.xpl # xpcPlugin/XPlaneConnect/win.xpl * Added ms azure ci xcode linux linux + macos linux + macos removed branch filter win tests win tests Test all platfroms artifacts tests * output all binaries to ‘XPlaneConnect’ All platforms produce a binary in xpcPlugin/XPlaneConnect/ xpcPlugin/XPlaneConnect/64/ * Added ms azure GH deploy deploy stage GH release test trigger tags * Clean up yml file - Added variables - Added job decriptions * Ignore script to ignore .exp files + fixed output path * Renamed ms azure GH connection
|
To add to @rthaenert comments, the SendComm functionality was erased during a force push to the develop branch. The release notes incorrectly make a reference to #120. The scope of that feature was fairly limited so my recommendation would be to |
|
The CI is technically working but @jason-watkins cannot grant the access to the nasa repo so he is running it in his fork |
|
Whoops... not sure how that happened. If someone wants resubmit the PR I'll re-merge it that way. Otherwise I'll do it myself when I have a chance. |
|
No worries, and this is why I usually disable force-push on my github repos 😄 I will take care of submitting a new PR. |
|
Yeah, I actually have other repos set up to entirely disable pushes to master and develop so that the only way code hits those branches is through a proper PR. This is a good reminder for me to ask for that to be enabled here too. |
Proposed release notes:
General Changes
New Features
Changes to the X-Plane Connect Plugin
Bug Fixes