-
-
Notifications
You must be signed in to change notification settings - Fork 373
Comparing changes
Open a pull request
base repository: napi-rs/napi-rs
base: napi@2.15.0
head repository: napi-rs/napi-rs
compare: napi@2.15.1
- 15 commits
- 16 files changed
- 5 contributors
Commits on Jan 27, 2024
-
chore(deps): update dependency esbuild to ^0.20.0 (#1925)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 949883b - Browse repository at this point
Copy the full SHA 949883bView commit details
Commits on Jan 29, 2024
-
fix(napi): Fix buffer corruption and soundness issues (#1923)
* fix(napi): Fix buffer corruption and soundness issues * test: fix tests to conform to buffer API
Configuration menu - View commit details
-
Copy full SHA for ac3626a - Browse repository at this point
Copy the full SHA ac3626aView commit details -
chore(deps): replace dependency npm-run-all with npm-run-all2 ^5.0.0 (#…
…1926) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [npm-run-all](https://togithub.com/mysticatea/npm-run-all) | devDependencies | replacement | [`^4.1.5` -> `^5.0.0`](https://renovatebot.com/diffs/npm/npm-run-all/4.1.5/) | This is a special PR that replaces `npm-run-all` with the community suggested minimal stable replacement version. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/napi-rs/napi-rs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Configuration menu - View commit details
-
Copy full SHA for 53adce9 - Browse repository at this point
Copy the full SHA 53adce9View commit details
Commits on Jan 31, 2024
-
chore(deps): update dependency npm-run-all2 to v6 (#1927)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 27367cf - Browse repository at this point
Copy the full SHA 27367cfView commit details -
chore(deps): update yarn to v4.1.0 (#1931)
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [yarn](https://togithub.com/yarnpkg/berry) ([source](https://togithub.com/yarnpkg/berry/tree/HEAD/packages/yarnpkg-cli)) | [`4.0.2` -> `4.1.0`](https://renovatebot.com/diffs/npm/yarn/4.0.2/4.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>yarnpkg/berry (yarn)</summary> ### [`v4.1.0`](https://togithub.com/yarnpkg/berry/blob/HEAD/CHANGELOG.md#410) [Compare Source](https://togithub.com/yarnpkg/berry/compare/a64075561a6476aa79d0fa1012ecf6b1633a88f2...52909a5e0d2fe72245957870bcd654218d93ef72) - Tweaks `-,--verbose` in `yarn workspaces foreach`; `-v` will now only print the prefixes, `-vv` will be necessary to also print the timings. - Adds a new `--json` option to `yarn run` when called without script name - Fixes `node-modules` linker `link:` dependencies mistreatment as inner workspaces, when they point to a parent folder of a workspace - Fixes spurious "No candidates found" errors - Fixes missing executable permissions when using `nodeLinker: pnpm` - Fixes packages being incorrectly flagged as optional - Fixes cache key corruptions due to uncontrolled git merges - Fixes `yarn version apply --all --dry-run` making unexpected changes - Fixes `yarn npm login` when the remote registry is Verdaccio </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/napi-rs/napi-rs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Configuration menu - View commit details
-
Copy full SHA for 556732d - Browse repository at this point
Copy the full SHA 556732dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5f3b2e - Browse repository at this point
Copy the full SHA a5f3b2eView commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0007e3a - Browse repository at this point
Copy the full SHA 0007e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 199893a - Browse repository at this point
Copy the full SHA 199893aView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 0177f59 - Browse repository at this point
Copy the full SHA 0177f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cca0c4 - Browse repository at this point
Copy the full SHA 9cca0c4View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 5e12280 - Browse repository at this point
Copy the full SHA 5e12280View commit details -
chore(deps): lock file maintenance (#1935)
[](https://renovatebot.com) This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/napi-rs/napi-rs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Configuration menu - View commit details
-
Copy full SHA for 44f536d - Browse repository at this point
Copy the full SHA 44f536dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c8d418 - Browse repository at this point
Copy the full SHA 2c8d418View commit details -
fix(napi): in "Object::get", return null values wrapped in a "Some" (#…
…1934) Hi 👋🏻, Alberto from @prisma here. We are users of the `serde-json` feature in [https://github.com/prisma/prisma-engines](https://github.com/prisma/prisma-engines/blob/23fdc5965b1e05fc54e5f26ed3de66776b93de64/Cargo.toml#L55-L60). ## The Problem While investigating a [user-reported Prisma issue](prisma/prisma#22294), we noticed that napi.rs treats `null` values in `Object` like `undefined` ones. However, `null` and `undefined` are semantically different in JavaScript: - `undefined` indicates that a value is not set - `null` indicates that a value has been explicitly set This PR, which we tested internally, fixes the user's issue on Prisma, and hopefully provides value to the `napi-rs` project as a whole. ## Scenario Consider [this scenario](https://github.com/prisma/prisma-engines/blob/dcb8cb9817af92fefaf0f95117dfb5dc19545a2c/query-engine/driver-adapters/src/napi/result.rs#L32-L33), effectively equivalent to: ```rust let napi_env: napi::sys::napi_env = /* ... */; let value: JsUnknown = object.get_named_property("value")?; // napi.rs implements the `FromNapiValue` trait for `serde_json` if // the `serde_json` feature is enabled (which we use already). let json = serde_json::Value::from_napi_value(napi_env, value.raw())?; Ok(Self::Ok(json.into())); ``` By looking at `napi.rs`' [`serde.rs` source file](https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/serde.rs), we [can see](https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/serde.rs#L104-L108) that "JSON subobjects" (`Map<String, serde_json::Value>`) are populated only if the value returned by `JsObject::get` is not `None`. This implies that, given `napi-rs`' [`Object::get` definition](https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/object.rs#L24-L44), `Object::get("key")` returns `None` both when the original object is ```js { // "key" is `undefined` } ``` and when the object is ```js { "key": null } ``` It just so happens that `prisma-engines` explicitly set a few `null` values explicitly for the features it offers, but these values are stripped away when we use the [napi-flavoured Prisma Query Engine](https://github.com/prisma/prisma-engines/tree/main/query-engine/query-engine-node-api). --- I am available for further comments, clarifications, and refactorings. Have a good day!
Configuration menu - View commit details
-
Copy full SHA for f40747a - Browse repository at this point
Copy the full SHA f40747aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b66467 - Browse repository at this point
Copy the full SHA 5b66467View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff napi@2.15.0...napi@2.15.1