Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2750 2750
=========================================
Hits 2750 2750 ☔ View full report in Codecov by Sentry. |
DragaDoncila
approved these changes
Mar 8, 2024
Contributor
DragaDoncila
left a comment
There was a problem hiding this comment.
Yep, looks great to me thanks @lucyleeow
jni
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing in CIs in #340.
I think it is because there is no warning raised (not sure why the
UserWarningis there). It used to pass because of this bug in pytest pytest-dev/pytest#9036, but this was fixed in pytest-dev/pytest#11129 and included in a recent release, thus our CIs are failing.Note that I have update the test to be more specific about the exception raised (
PackageNotFoundError) but it is not needed, subclass exceptions are still accepted by pytest. Also added a message to be more specific.