Skip to content

Move from appdirs to platformdirs#8797

Merged
willingc merged 4 commits intonapari:mainfrom
Czaki:platformdirs
Apr 3, 2026
Merged

Move from appdirs to platformdirs#8797
willingc merged 4 commits intonapari:mainfrom
Czaki:platformdirs

Conversation

@Czaki
Copy link
Copy Markdown
Collaborator

@Czaki Czaki commented Mar 23, 2026

References and relevant issues

Description

The last appdirs release was May 11 2020. Then platformdirs take its place. It introduces many improvements like allow to overwrite dirs using XDG_* variables

tox-dev/platformdirs#375

So I think we should switch to platformdirs

@Czaki Czaki added this to the 0.7.1 milestone Mar 23, 2026
@Czaki Czaki requested a review from a team as a code owner March 23, 2026 11:51
@Czaki Czaki added the maintenance PR with maintance changes, label Mar 23, 2026
@github-actions github-actions bot added the tests Something related to our tests label Mar 23, 2026
@psobolewskiPhD
Copy link
Copy Markdown
Member

psobolewskiPhD commented Mar 23, 2026

I recall making this change already? 🤔

willingc
willingc approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this cleanup @Czaki. 🚢

@willingc
Copy link
Copy Markdown
Collaborator

willingc commented Mar 23, 2026

@Czaki Failing check is due to npe2 and napari-plugin-manager.

Screenshot 2026-03-23 at 7 04 05 AM

@Czaki
Copy link
Copy Markdown
Collaborator Author

Czaki commented Mar 23, 2026 •
edited
Loading

@willingc The napari-plugin-manager has nothing to do here. See this issue in uv.
astral-sh/uv#17960

But yes the conflict is between my lower bound on platformdirs and npe2 one. Will fix

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.32%. Comparing base (1bf8f80) to head (dc61490).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/napari/utils/info.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8797      +/-   ##
==========================================
+ Coverage   93.24%   93.32%   +0.08%     
==========================================
  Files         706      706              
  Lines       64909    64909              
==========================================
+ Hits        60523    60578      +55     
+ Misses       4386     4331      -55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Mar 23, 2026
@willingc willingc merged commit 6c8440a into napari:main Apr 3, 2026
38 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

Assignees

No one assigned

Labels

maintenance PR with maintance changes, tests Something related to our tests

Projects

None yet

Milestone

0.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Czaki @psobolewskiPhD @willingc