Skip to content

Support error reporting via napari-error-reporter#4055

Merged
tlambert03 merged 9 commits intonapari:mainfrom
tlambert03:error-reporting
Feb 12, 2022
Merged

Support error reporting via napari-error-reporter#4055
tlambert03 merged 9 commits intonapari:mainfrom
tlambert03:error-reporting

Conversation

@tlambert03
Copy link
Copy Markdown
Contributor

@tlambert03 tlambert03 commented Feb 4, 2022 •
edited
Loading

Description

Resubmission of #4040 that got merged too soon. (approved by @DragaDoncila and @alisterburt, waiting on @jni)

Summary of changes since then:

  • upstream package changed to napari-error-reporter
  • decision made to restrict bug report access to those explicitly listed in https://github.com/tlambert03/napari-error-reporter/blob/main/ADMINS
  • any issues created in the napari repo from those bug reports will be manually inspected for leaked personally identifiable info, and it will be removed prior to posting here.
  • if that file changes (i.e. admins are added) then users will be asked to re-opt in, and they'll see a list of admins and links to their github pages
  • clarified some things in the opt in widget, which now looks like this:

Untitled

@github-actions github-actions bot added the qt Relates to qt label Feb 4, 2022
@tlambert03 tlambert03 requested review from jni and sofroniewn February 4, 2022 04:45
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #4055 (1bfc7c3) into main (df6af50) will increase coverage by 0.00%.
The diff coverage is 92.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4055   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         591      591           
  Lines       48944    48969   +25     
=======================================
+ Hits        40761    40784   +23     
- Misses       8183     8185    +2
Impacted Files Coverage Δ
napari/_qt/menus/help_menu.py 93.33% <83.33%> (-6.67%) ⬇️
napari/conftest.py 85.07% <90.00%> (+0.25%) ⬆️
napari/utils/notifications.py 86.30% <100.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6af50...1bfc7c3. Read the comment docs.

@tlambert03 tlambert03 changed the title Support error reporting via napari-error-monitor Support error reporting via napari-error-reporter Feb 11, 2022
@tlambert03 tlambert03 removed the request for review from sofroniewn February 11, 2022 21:38
@tlambert03
Copy link
Copy Markdown
Contributor Author

tlambert03 commented Feb 11, 2022 •
edited
Loading

ready for review @jni with v0.2.1 of napari-error-reporter now the only one on pypi

PS. I verified that if there is no internet connection, nothing happens (the user isn't interrupted in any way, it just fails to send)

@tlambert03 tlambert03 merged commit e13f865 into napari:main Feb 12, 2022
@tlambert03 tlambert03 deleted the error-reporting branch February 12, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jni jni jni approved these changes

Assignees

@tlambert03 tlambert03

Labels

qt Relates to qt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tlambert03 @jni