Fix examples path in build_docs PR workflow#8
Merged
jni merged 6 commits intonapari:mainfrom Oct 16, 2022
Merged
Conversation
jni
approved these changes
Oct 16, 2022
Member
jni
left a comment
There was a problem hiding this comment.
I think indeed that this is nicer! 🙏
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build action appears to be failing, see https://github.com/napari/docs/actions/runs/3254781307 with an error related to the path of the examples:
I try to fix the nesting, because it is tricky: the docs building on
napari/napari(also failing at the moment see: https://github.com/napari/napari/actions/runs/3254935774) use this sameconf.py. Hence doing the same copy step to ensure the paths are correct. This will fix the failing napari workflow too, because now conf.py should be correct—tested with my forks:Here's the docs fork, showing the workflow works:
https://github.com/psobolewskiPhD/napari-docs/actions/runs/3255346428
and here's my napari fork, showing that workflow now works with no changes:
https://github.com/psobolewskiPhD/napari/actions/runs/3255523293
Type of change
References
How has this been tested?
Final checklist:
trans.to make them localizable.For more information see our translations guide.