Update where app-model actions/providers/processors live in codebase #416
Merged
DragaDoncila merged 4 commits intonapari:mainfrom Jun 7, 2024
Merged
Update where app-model actions/providers/processors live in codebase #416DragaDoncila merged 4 commits intonapari:mainfrom
DragaDoncila merged 4 commits intonapari:mainfrom
Conversation
Collaborator
Author
DragaDoncila
reviewed
May 3, 2024
Contributor
DragaDoncila
left a comment
There was a problem hiding this comment.
Thanks @lucyleeow just some nits here
| of living in a menu and are thus considered 'Qt' actions. | ||
| This also ensures that there is only one file defining. | ||
|
|
||
| The layer context menu actions do not require a GUI and thus live in |
Contributor
There was a problem hiding this comment.
Suggested change
| The layer context menu actions do not require a GUI and thus live in | |
| The layer context menu actions do not require a GUI (they only require the `layerlist`) and thus live in |
Collaborator
Author
|
Thanks, changes made! |
DragaDoncila
approved these changes
May 3, 2024
Contributor
DragaDoncila
left a comment
There was a problem hiding this comment.
Awesome sauce, thanks @lucyleeow!
Collaborator
Author
|
AH whoops sorry, I forgot this has already been approved. I realise that we now no longer have qt providers or processors anymore, so I've updated that here too. Sorry! |
napari codebase napari codebase
napari codebase
Contributor
|
@lucyleeow do we now have to wait for #6743 to go in before we merge this? |
Collaborator
Author
|
🤦 yes you are right. I'll add a depends on |
Contributor
|
test comment |
Collaborator
Author
|
The depends on has now been merged (not sure why the CI is still failing) so maybe this could go in now, @DragaDoncila ? |
Contributor
|
thanks @lucyleeow sorry for the delay... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Relates to napari/napari#6848
Depends on napari/napari#6743
Description
Updates the info on where actions live in the napari codebase.