Simplify Boost libs integration#5037
Merged
pwojcikdev merged 2 commits intonanocurrency:developfrom Feb 27, 2026
Merged
Conversation
Test Results for Commit 79d9394Pull Request 5037: Results Test Case Results
Last updated: 2026-02-27 19:05:48 UTC |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s CMake-based Boost integration to rely on Boost’s top-level CMake (submodules/boost) and BOOST_INCLUDE_LIBRARIES for selecting only the Boost libraries directly used by nano-node, letting Boost handle transitive dependencies automatically.
Changes:
- Replaces manual
add_subdirectory(submodules/boost/libs/<lib>)enumeration withBOOST_INCLUDE_LIBRARIES+ a singleadd_subdirectory(submodules/boost ...). - Removes the
boost_property_treeinterface link “workaround” that manually injected missing dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CMakeLists.txt
Outdated
Comment on lines
+410
to
+411
| # Then set up boost modules Only list libraries directly used by nano-node; | ||
| # BoostRoot resolves transitive dependencies automatically. |
There was a problem hiding this comment.
The Boost setup comment reads as two sentences run together ("modules Only list..."). Please split into separate sentences/lines (and add missing punctuation) to keep the CMakeLists comment readable and unambiguous.
Suggested change
| # Then set up boost modules Only list libraries directly used by nano-node; | |
| # BoostRoot resolves transitive dependencies automatically. | |
| # Then set up Boost modules. | |
| # Only list libraries directly used by nano-node; BoostRoot resolves transitive dependencies automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use BOOST_INCLUDE_LIBRARIES with only direct dependencies instead of manually listing 70+ transitive Boost sub-libraries.
Also removes boost_property_tree link workaround (now handled automatically)