Standardizing terminology to distinguish between confirmed vs cemented#5032
Merged
pwojcikdev merged 6 commits intonanocurrency:developfrom Feb 14, 2026
Merged
Conversation
dc7ace4 to
821506c
Compare
Test Results for Commit 7e31e4aPull Request 5032: Results Test Case Results
Last updated: 2026-02-14 12:57:31 UTC |
821506c to
f2cca4a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes terminology throughout the codebase to distinguish between:
- Election confirmation: Consensus achieved through voting (user-facing: "confirmed")
- Ledger cementing: Blocks permanently written to disk (internal: "cemented")
The refactoring renames internal ledger components and methods from "confirmed" to "cemented" while maintaining user-facing messages that use "confirmed" terminology.
Changes:
- Renamed ledger class
ledger_set_confirmedtoledger_set_cementedincluding header, implementation, and all references - Renamed ledger members
confirmed_impl/confirmedtocemented_impl/cemented - Renamed method
dependencies_confirmed()todependencies_cemented() - Renamed method
confirm()tocement()andconfirm_one()tocement_one() - Renamed method
unconfirmed_exists()toblock_uncemented() - Updated statistics enum values:
blocks_confirmed*→blocks_cemented* - Removed unused
process_confirmed_intervalconstant and related logging/stats types - Updated all test files to use new naming conventions
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| nano/secure/ledger_set_confirmed.hpp | Removed old header file |
| nano/secure/ledger_set_cemented.hpp | New header with renamed class and methods |
| nano/secure/ledger_set_cemented.cpp | Implementation file with all class/method renames |
| nano/secure/ledger.hpp | Updated to use cemented terminology in members and methods |
| nano/secure/ledger.cpp | Renamed cement() method and updated all internal usage |
| nano/secure/ledger_set_any.hpp | Updated forward declarations and formatting |
| nano/secure/receivable_iterator.cpp | Updated template instantiation |
| nano/secure/common.hpp/cpp | Removed unused process_confirmed_interval constant |
| nano/secure/CMakeLists.txt | Updated build files with new filenames |
| nano/lib/stats_enums.hpp | Renamed stats details to use cemented terminology |
| nano/lib/logging_enums.hpp | Removed unused process_confirmed logging detail |
| nano/node/*.cpp | Updated all node components to use ledger.cemented API |
| nano/node/scheduler/*.cpp | Updated schedulers to use dependencies_cemented() |
| nano/node/nodeconfig.cpp | Removed validation for deleted process_confirmed_interval |
| nano/core_test/ledger_cement.cpp | Renamed test file and updated all test names |
| nano/core_test/*.cpp | Updated all test code to use new API |
| nano/core_test/CMakeLists.txt | Updated build configuration |
| nano/slow_test/*.cpp | Updated slow tests to use new API |
| nano/rpc_test/rpc.cpp | Updated RPC tests |
| nano/qt_test/qt.cpp | Updated Qt tests |
| nano/test_common/*.cpp | Updated test utilities |
| nano/nano_node/benchmarks/*.cpp | Updated benchmarks |
Comments suppressed due to low confidence (2)
nano/core_test/ledger_cement.cpp:835
- The comment still refers to a block being "marked to be confirmed" but should use "cemented" terminology to match the function name and overall terminology standardization.
nano/core_test/ledger_cement.cpp:216 - The comment uses "confirmed" terminology, which should be updated to "cemented" for consistency: "The accounts for key1 and key2 have 1 more block in the chain than is cemented."
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Qualify `secure::transaction` as `nano::secure::transaction` and remove unused parameter names from declarations.
f2cca4a to
7e31e4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminology standardization to distinguish between:
Changes: