Move receivable scan to dedicated wallets thread#5011
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Jan 25, 2026
Merged
Move receivable scan to dedicated wallets thread#5011pwojcikdev merged 1 commit intonanocurrency:developfrom
pwojcikdev merged 1 commit intonanocurrency:developfrom
Conversation
Test Results for Commit 10c10edPull Request 5011: Results Test Case Results
Last updated: 2026-01-25 21:31:45 UTC |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the receivable block scanning functionality by moving it from a delayed task on the node's worker thread pool to a dedicated background thread in the wallets component, following the same pattern established by the existing representative scanning thread.
Changes:
- Created a dedicated
receivable_threadin the wallets class that continuously scans for receivable blocks - Removed the recursive
node::search_receivable_all()method that used worker thread scheduling - Added appropriate thread role and statistics enums for the new thread
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| nano/node/wallet.hpp | Added run_receivable_scan() method declaration, receivable_condition condition variable, and receivable_thread member |
| nano/node/wallet.cpp | Implemented run_receivable_scan() loop, thread initialization in start(), and cleanup in stop() |
| nano/node/node.hpp | Removed search_receivable_all() method declaration from node class |
| nano/node/node.cpp | Removed search_receivable_all() implementation and its call from node::start() |
| nano/lib/thread_roles.hpp | Added wallet_receivable thread role enum value |
| nano/lib/thread_roles.cpp | Added string mapping for wallet_receivable thread role |
| nano/lib/stats_enums.hpp | Added loop_receivable statistic detail enum value |
| nano/core_test/wallets.cpp | Added comprehensive test for the background receivable scanning functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.