Fix race in disabled_when_principal_representative test#5008
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Jan 25, 2026
Merged
Conversation
Test Results for Commit c4e928cPull Request 5008: Results Test Case Results
Last updated: 2026-01-24 20:38:52 UTC |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the disabled_when_principal_representative test by moving the node.stats.clear() call to occur before waiting for the rebroadcaster refresh events.
Changes:
- Moved
node.stats.clear()from line 426 to line 389, positioning it before theASSERT_TIMELYcheck for refresh events - This ensures the test waits for refresh events from a known baseline rather than potentially passing immediately due to pre-existing refresh counts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.