Migrate successor data from sideband to dedicated table#4967
Closed
RickiNano wants to merge 11 commits intonanocurrency:developfrom
Closed
Migrate successor data from sideband to dedicated table#4967RickiNano wants to merge 11 commits intonanocurrency:developfrom
RickiNano wants to merge 11 commits intonanocurrency:developfrom
Conversation
Test Results for Commit 74645f9Pull Request 4967: Results Test Case Results
Last updated: 2025-11-26 20:52:11 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the successor field from the sideband data and into a new table named successors. This simplifies parts of the code and it paves the way for the splitting the blocks table as described in #4053
I have tested the code with LMDB and Rocksdb by bootstrapping from scratch. I have also migrated a recent ledger database of both backend types