Skip to content

Fix out of order ledger notifications#4824

Merged
pwojcikdev merged 5 commits intonanocurrency:developfrom
pwojcikdev:ledger-notifications-3
Jan 17, 2025
Merged

Fix out of order ledger notifications#4824
pwojcikdev merged 5 commits intonanocurrency:developfrom
pwojcikdev:ledger-notifications-3

Conversation

@pwojcikdev
Copy link
Copy Markdown
Contributor

This fixes the issue with bootstrap stalls when bounded backlog is enabled.

We issue ledger notifications on a separate background thread for performance reasons to avoid unnecessary work on threads that perform ledger writes. Because of this both block processor and bounded backlog classes modify ledger and issue their notifications from their own background workers, which will as currently implemented will lead to some strange interleavings.

This implements a component that manages a single thread that issues ledger modification notifications in the same exact order they were performed.

@pwojcikdev pwojcikdev force-pushed the ledger-notifications-3 branch from ee47806 to 5ed3aab Compare January 14, 2025 21:35
@gr0vity-dev-bot
Copy link
Copy Markdown

gr0vity-dev-bot commented Jan 14, 2025

Test Results for Commit 5ed3aab

Pull Request 4824: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 118s)
  • 5n4pr_conf_10k_change: PASS (Duration: 132s)
  • 5n4pr_conf_change_dependant: PASS (Duration: 127s)
  • 5n4pr_conf_change_independant: PASS (Duration: 117s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 129s)
  • 5n4pr_conf_send_independant: PASS (Duration: 122s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 108s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 150s)

Last updated: 2025-01-14 22:58:48 UTC

@pwojcikdev pwojcikdev merged commit 0db11e8 into nanocurrency:develop Jan 17, 2025
@qwahzi qwahzi added this to the V28 milestone Jan 18, 2025
@qwahzi qwahzi moved this from In Progress / V28.0 to Merged / V28.0 in Nano Roadmap Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged / V28.0

Development

Successfully merging this pull request may close these issues.

3 participants