Various cleanups to store classes#4760
Merged
clemahieu merged 4 commits intonanocurrency:developfrom Oct 21, 2024
Merged
Conversation
Test Results for Commit c659c8bPull Request 4760: Results Test Case Results
Last updated: 2024-10-20 22:42:34 UTC |
2d2e762 to
d4455e4
Compare
d4455e4 to
c659c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use unqualified names and type inference when possible.
Add type aliases for iterators in store classes.
Rename store/final.hpp to store/final_vote.hpp to match names in lmdb and rocksdb backend.