Limit batch size for block processor#4655
Merged
pwojcikdev merged 2 commits intonanocurrency:developfrom Jul 3, 2024
Merged
Conversation
clemahieu
approved these changes
Jul 2, 2024
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
Minor question about getting batches from the fair_queue though otherwise LGTM. This was a badly needed cleanup.
|
|
||
| lock_a.lock (); | ||
| std::deque<context> results; | ||
| while (!queue.empty () && results.size () < max_count) |
Contributor
There was a problem hiding this comment.
Doesn't fair_queue already have a next_batch()?
Contributor
Author
There was a problem hiding this comment.
It has, but there were some additional checks in the block_processor::next () so it wasn't a drop in replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This limits a single block processor batch size to 256 blocks. This makes batch sizes uniform across all components. Additionally, if disk is slow and database transaction is held longer than 500ms, the transaction is refreshed during batch processing.