Run UPNP port mapping on a dedicated thread#4591
Merged
pwojcikdev merged 3 commits intonanocurrency:developfrom Apr 29, 2024
Merged
Run UPNP port mapping on a dedicated thread#4591pwojcikdev merged 3 commits intonanocurrency:developfrom
pwojcikdev merged 3 commits intonanocurrency:developfrom
Conversation
clemahieu
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the
port_mappingcomponent responsible for port redirection configuration to run on a dedicated thread. This should help with node resiliency.However, the problem I noticed is that testing
port_mappingcomponent doesn't seem to be part of our CI. There is a comment indicating that maybe this was attempted in the past:I'd recommend that we look into it. Perhaps it can be done as part of our system test suite.