Vote generator write queue#4556
Merged
clemahieu merged 2 commits intonanocurrency:developfrom Apr 13, 2024
Merged
Conversation
Add consistency check to ensure the writer token is not already queued since they're waited for by value. Change wait-loop to use the predicated overload of wait.
Previously the vote_generator was not respecting the write_queue.
pwojcikdev
approved these changes
Apr 13, 2024
Contributor
pwojcikdev
left a comment
There was a problem hiding this comment.
Was there any performance or stability problem with previous code? Or it's just for consistency?
Contributor
Author
Yea there was a weird behavior where one of the schedulers (I think hinted) would 95% of the time execute something instantly but sometimes it would take multiple seconds. This was on the transaction locks branch so it's hard to tell since that's still being debugged. It's worth a new performance analysis with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the vote_generators to respect the database write queue.
Add consistency check to ensure the writer token is not already queued since they're waited for by value.
Change wait-loop to use the predicated overload of wait.