Reorganize tcp_listener#4515
Merged
pwojcikdev merged 4 commits intonanocurrency:developfrom Mar 22, 2024
Merged
Conversation
clemahieu
reviewed
Mar 21, 2024
nano/node/transport/tcp_server.cpp
Outdated
| std::size_t nano::transport::tcp_listener::connection_count () | ||
| { | ||
| nano::lock_guard<nano::mutex> lock{ mutex }; | ||
| cleanup (); |
Contributor
There was a problem hiding this comment.
This seems like an odd place to do cleanup.
Contributor
Author
There was a problem hiding this comment.
Yes, it's less than ideal, but this is an intermediate step before doing larger refactoring.
clemahieu
approved these changes
Mar 21, 2024
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
Looks good if the cleanup is going to be called in a more reliable place in future patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation for future
tcp_listenerchanges. It doesn't change functionality of the class significantly, but moves it to a dedicated file and reduces header coupling.