Preliminary network class cleanup#4490
Merged
pwojcikdev merged 9 commits intonanocurrency:developfrom Mar 15, 2024
Merged
Conversation
clemahieu
approved these changes
Mar 15, 2024
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
This looks good. It makes significant inroads on the thousand annoyances with the networking code.
| std::shared_ptr<nano::transport::socket> socket; | ||
| }; | ||
|
|
||
| class tcp_message_manager final |
Contributor
There was a problem hiding this comment.
Could probably be in its own file.
Contributor
Author
There was a problem hiding this comment.
I don't want to spend to much time on reworking this manager, since I plan to move this functionality to a message_processor class anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for future network improvements, this PR reorganizes
networkclass slightly, makes dedicated threads for long lived tasks and removes unused code.