Larger votes preparation#4350
Merged
pwojcikdev merged 3 commits intonanocurrency:developfrom Dec 12, 2023
Merged
Conversation
2cb9bdc to
632b73e
Compare
clemahieu
approved these changes
Dec 12, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This allows nodes to handle
confirm_reqandconfirm_ackmessages with payload of more than 16 hashes, up to 255. During testing it was shown that fewer, larger messages provide considerable improvement in performance, especially on CPU limited hardware. This PR is one of the steps to better align our message formats with this philosophy.What's important to note is that, even with ability to handle large votes, nodes will continue to generate vote requests & responses with legacy rules (<= 12 hashes per message) to keep compatibility with previous versions. Once majority of the network upgrades, switching to larger votes should be as simple as modifying two constants in code.