Remove vote-by-block support for confirm req message#4341
Merged
pwojcikdev merged 2 commits intonanocurrency:developfrom Dec 1, 2023
Merged
Remove vote-by-block support for confirm req message#4341pwojcikdev merged 2 commits intonanocurrency:developfrom
pwojcikdev merged 2 commits intonanocurrency:developfrom
Conversation
clemahieu
reviewed
Nov 11, 2023
clemahieu
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vote-by-block support was largely removed in #3813. This PR removes the remaining legacy part in confirm req message in order to free header fields for future upgrades. According to nanolooker, there are no pre-V24 representatives on the live network that could still rely on this functionality. It is important to note is that, while the
block_typeheader field will be ignored starting with this version, it still needs to be set for compatibility with <= V25.1 nodes. The complete removal of this field will be possible only after all nodes have been updated to the current version.