Remove atomic enum election::state_m and instead require locking election::mutex.#4318
Merged
clemahieu merged 9 commits intonanocurrency:developfrom Jan 16, 2024
Merged
Conversation
298b348 to
e174edf
Compare
Contributor
|
@clemahieu, could you explain why this change is needed, what problem does it solve. |
Contributor
Author
|
This change is removing the atomic election::state_m variable in favor of using the election mutex for synchronization. The issue is there are two synchronization mechanisms in use, locking the mutex or doing an atomic compare exchange, which has race conditions. From what I recall the election can be doing an operation with a locked mutex, and a separate action can change the election state because it doesn't respect the mutex being locked. |
…oesn't need to be evaluated when debugging is off.
A mutex was needlessly being passed from function to function and a function wrapper existed needlessly.
97595c8 to
345e1d8
Compare
…able The critical section is now obvious and easy to see
345e1d8 to
b44be68
Compare
dsiganos
approved these changes
Jan 16, 2024
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.