Force use of windows.h instead of default winnt.h#4288
Merged
clemahieu merged 2 commits intonanocurrency:developfrom Sep 21, 2023
Merged
Force use of windows.h instead of default winnt.h#4288clemahieu merged 2 commits intonanocurrency:developfrom
clemahieu merged 2 commits intonanocurrency:developfrom
Conversation
This fixes the "No target Architecture" error when building on windows. The windows.h include needs to be before processthreadapi.h to work properly but clang complains about this
Contributor
|
Looks like clang format doesn't like the non-alphabetical order of headers. Is processthreadsapi.h needed at all with windows.h? |
Contributor
Author
|
You are right. It still builds without the processthreadsapi.h include. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the "No target Architecture" error when building on windows.
Clang format will report an error but the windows.h include must be before processthreadapi.h to work properly.