fixed bug in nano::rocksdb::store::clear()#4279
Closed
brandon-bb wants to merge 2 commits intonanocurrency:developfrom
Closed
fixed bug in nano::rocksdb::store::clear()#4279brandon-bb wants to merge 2 commits intonanocurrency:developfrom
brandon-bb wants to merge 2 commits intonanocurrency:developfrom
Conversation
… applied to the column family
clemahieu
approved these changes
Sep 12, 2023
Contributor
|
If you can rebase this I will merge it. |
Contributor
|
I took the liberty of cherrypicking the commits to a new PR to resolve the merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3911 - issue before was that the function was deleting the column entirely to clear the contents then adding it back. This solution makes use of the atomic update feature in RocksDB by creating a batch of delete operations for all keys in the column and applying them with a write operation. This approach ensures that either all operations are applied or none are, thus guaranteeing database consistency.