Remove separate signature checking thread classes#4267
Merged
clemahieu merged 5 commits intonanocurrency:developfrom Nov 6, 2023
Merged
Remove separate signature checking thread classes#4267clemahieu merged 5 commits intonanocurrency:developfrom
clemahieu merged 5 commits intonanocurrency:developfrom
Conversation
530d91e to
32a2e4e
Compare
32a2e4e to
0518ab8
Compare
0518ab8 to
47889a2
Compare
47889a2 to
5f5ae98
Compare
pwojcikdev
previously approved these changes
Oct 19, 2023
Contributor
pwojcikdev
left a comment
There was a problem hiding this comment.
Good PR that removes unnecessary complexity, all the checks were performed inside the ledger_processor anyway.
5f5ae98 to
69bba0c
Compare
pwojcikdev
previously approved these changes
Nov 5, 2023
c9e2073 to
f150aab
Compare
…or::blocks regardless of type. Negative testing for signatures of state/epoch blocks is done with ledger.fail_state_bad_signature and ledger.fail_epoch_bad_signature. Signature checking is always done within the block verification functions themselves since nanocurrency#4021
pwojcikdev
previously approved these changes
Nov 6, 2023
f150aab to
dc536b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the use of separate signature-checking threads/classes from the node.
These classes add complexity to critical code. Even where performance optimizations could be made through multi-threading, it would be better implemented using standard C++ instead of a custom class.
It's unclear if these classes are helping performance at all so we're opting to remove them until/if a performance improvement is needed.
This PR contains 4 commits: