Skip to content

feat: Enhance GitHub Actions "Code Sanitizers" Workflow#4258

Closed
gr0vity-dev wants to merge 3 commits intonanocurrency:developfrom
gr0vity-dev:prs/update_code_sanitizers
Closed

feat: Enhance GitHub Actions "Code Sanitizers" Workflow#4258
gr0vity-dev wants to merge 3 commits intonanocurrency:developfrom
gr0vity-dev:prs/update_code_sanitizers

Conversation

@gr0vity-dev
Copy link
Copy Markdown
Contributor

This commit includes several improvements for our GitHub Actions workflows:

  • Removed the need for 'nano-env' Docker images, and adjusted commands to be run directly.
  • Increase the timeout limit from 90 to 120 minutes to accommodate longer running tests.
  • Add inidividual timeouts fro core_test and rpc_test to always create a report, even in the case of a TSAN deadlock.
  • Set submodules: "recursive" on checkout instead of having an special step to do this

These changes are intended to reduce the complexity of our CI/CD process.

@gr0vity-dev gr0vity-dev force-pushed the prs/update_code_sanitizers branch from 540c705 to fde04eb Compare August 18, 2023 15:19
gr0vity-dev and others added 3 commits August 18, 2023 17:35
- Run testcases with sanitizers directly on ubuntu 22.04 github runners
- use space instead of colon as separator for TSAN_OPTIONS and ASAN_OPTIONS
- add timeout for core_test (45min) and rpc_test (20min) to produce a report in case of a deadlock
In case no report is created, there is an error message which is not useful :
`ls: cannot access 'build/sanitizer_report*': No such file or directory`
This case is treated in the else condition already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant