Fix blake2 and argon2 building on Windows ARM#4220
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Apr 26, 2023
Merged
Fix blake2 and argon2 building on Windows ARM#4220pwojcikdev merged 1 commit intonanocurrency:developfrom
pwojcikdev merged 1 commit intonanocurrency:developfrom
Conversation
clemahieu
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building node for Windows, it was always assumed that it's targeting x86, which led to cryptographic libraries (blake2 and argon2) failing to build on Windows for ARM. This PR fixes that. It is now possible to build a native ARM node for Windows, however it will be using the slower reference implementation. It might be worth looking into conditionally using an implementation taking advantage of neon intrinsics, similar to the way we do it on x86.