Remove the unchecked table code from the store classes#4216
Merged
thsfs merged 5 commits intonanocurrency:developfrom Apr 21, 2023
Merged
Remove the unchecked table code from the store classes#4216thsfs merged 5 commits intonanocurrency:developfrom
thsfs merged 5 commits intonanocurrency:developfrom
Conversation
added 5 commits
April 19, 2023 14:54
Kept the lmdb::unchecked_store because it contains the LMDB file handler that will be used by the database upgrade code (to be added).
The same test can be performed using a different RocksDB table.
clemahieu
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a removal of the unchecked table code that is not in use anymore. After this PR, there will be still some database level implementation, but that will be tweaked in further PRs (such as #4131) for compatibility reasons only.