Skip to content

Updating flatbuffer library version.#4173

Merged
clemahieu merged 2 commits intonanocurrency:developfrom
clemahieu:flatbuffer_version_bump
Mar 7, 2023
Merged

Updating flatbuffer library version.#4173
clemahieu merged 2 commits intonanocurrency:developfrom
clemahieu:flatbuffer_version_bump

Conversation

@clemahieu
Copy link
Copy Markdown
Contributor

The file nano/ipc_flatbuffers_lib/generated/flatbuffers/nanoapi_generated.h will need to be regenerated by deleting the file and rebuilding.

An error like: error: no matching function for call to ‘nanoapi::Envelope::VerifyField<uint8_t> indicates the file has not been regenerated.

@clemahieu clemahieu added routine This item indicates the need for or supplies a routine change exclude from changelog Indicates the change is not relevant for appearing in the release changelog labels Mar 6, 2023
@clemahieu clemahieu added this to the V25.0 milestone Mar 6, 2023
@clemahieu clemahieu requested a review from thsfs March 6, 2023 11:18
thsfs
thsfs previously approved these changes Mar 6, 2023
The file nano/ipc_flatbuffers_lib/generated/flatbuffers/nanoapi_generated.h will need to be regenerated by deleting the file and rebuilding.

An error like: error: no matching function for call to ‘nanoapi::Envelope::VerifyField<uint8_t> indicates the file has not been regenerated.

Adding -DNOGDI flag for WIN32 to prevent the ERROR macro within wingdi.h from colliding with ProtoIdGapAction::ERROR
@clemahieu clemahieu force-pushed the flatbuffer_version_bump branch from d3db4bd to c9e052f Compare March 6, 2023 14:43
@thsfs thsfs force-pushed the flatbuffer_version_bump branch from 33d9f41 to b4fdc07 Compare March 6, 2023 17:00
thsfs
thsfs previously approved these changes Mar 6, 2023
@thsfs thsfs requested a review from dsiganos March 6, 2023 19:24
Remove -k option, that doesn't exist for cmake.
@clemahieu clemahieu merged commit 75c6ef6 into nanocurrency:develop Mar 7, 2023
@thsfs thsfs added the documentation This item indicates the need for or supplies updated or expanded documentation label Mar 8, 2023
@thsfs
Copy link
Copy Markdown
Contributor

thsfs commented Mar 8, 2023

Requires updating the documentation website regarding the Ubuntu requirement to be 22.04+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This item indicates the need for or supplies updated or expanded documentation exclude from changelog Indicates the change is not relevant for appearing in the release changelog routine This item indicates the need for or supplies a routine change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants