Migrate tests from the old message_parser to test the message_deserializer class#4166
Merged
thsfs merged 8 commits intonanocurrency:developfrom Mar 7, 2023
Conversation
added 8 commits
March 2, 2023 22:32
The old test checked the bytes generated the same confirm_ack object by ensuring its visitor was processed only once. Also verified the parse_status was success. In the new implementation the visitor isn't part of the deserializer. The outcome object is compared to the original, and the parse_status should be success. This is the sanity test, where the deserialization is expected to happen successfully. Also checks if the message pointer can be downcast to the proper type, that is the same of verifying its type is supported.
clemahieu
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
message_parserclass is not used any more and will be removed soon. More tests are needed to themessage_deserializerclass. This PR covers the support and the integrity of the different message types handled.