Refactor election vote#4119
Merged
clemahieu merged 9 commits intonanocurrency:developfrom Feb 17, 2023
Merged
Conversation
…lse at this point.
clemahieu
approved these changes
Feb 15, 2023
dsiganos
reviewed
Feb 15, 2023
Contributor
|
Also, that if statement looks like an important one. And it looks like we are missing a test case for it. |
dsiganos
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring nano::election::vote method according to #4108.
Main goals:
Reduce nesting of if statements
Use early returns
Simplify longer if statement.