Fix magic enum slow compilation times#4113
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Feb 8, 2023
Merged
Conversation
clemahieu
approved these changes
Feb 8, 2023
dsiganos
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing magic_enum slowed down our compilation times. The reason for that is that it's a library relying heavily on templates and it was used from inline methods in a header file. That resulted in a lot of unnecessary recompilations of the same code. This PR moves that implementation to a .cpp file, so it only needs to be compiled once. In addition it also solves the annoying macro redefinition warnings.