Add ledger::pending_info as interface to access pending information#4087
Merged
clemahieu merged 1 commit intonanocurrency:developfrom Jan 28, 2023
Merged
Conversation
…ledger::pending_info interface to query for pending information. Result is returned as an std::optional instead of the less-obvious way it's currently reported through an error code. Most though not all of the pending_store::get references have been updated to use ledger::pending_info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than directly accessing the block store, users should use the ledger::pending_info interface to query for pending information.
Result is returned as an std::optional instead of the less-obvious way it's currently reported through an error code.
Most though not all of the pending_store::get references have been updated to use ledger::pending_info.