Move websocket initialization code out of node constructor#4068
Merged
pwojcikdev merged 2 commits intonanocurrency:developfrom Jan 24, 2023
Merged
Move websocket initialization code out of node constructor#4068pwojcikdev merged 2 commits intonanocurrency:developfrom
pwojcikdev merged 2 commits intonanocurrency:developfrom
Conversation
31312a7 to
26aadc4
Compare
clemahieu
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node constructor is currently a very crowded place, which makes it harder than needed to understand and work with. Ideally, node should only concern itself with high level initialization, leaving details to be implemented in component classes. This PR is an attempt to take a bite out of this problem and move websocket setup code to a dedicated class.