Skip to content

Removed all unnecessary usings#4049

Merged
clemahieu merged 1 commit intonanocurrency:developfrom
RickiNano:clean-up-includes
Jan 13, 2023
Merged

Removed all unnecessary usings#4049
clemahieu merged 1 commit intonanocurrency:developfrom
RickiNano:clean-up-includes

Conversation

@RickiNano
Copy link
Copy Markdown
Contributor

Removed unnecessary usings from the node project.
Compiled and tested manually.
Unit tests completed successfully

@dsiganos
Copy link
Copy Markdown
Contributor

Did you use an automated process to remove them?

@RickiNano
Copy link
Copy Markdown
Contributor Author

@dsiganos
Yes. I used the c++ resharper plugin for Visual Studio

@dsiganos
Copy link
Copy Markdown
Contributor

Do you know how it decides if an include is needed or not?
How does it deal with #ifdefs?

@clemahieu clemahieu merged commit 5511ec2 into nanocurrency:develop Jan 13, 2023
@RickiNano
Copy link
Copy Markdown
Contributor Author

I don't know how it checks if a using is needed but it seems to have done a good job

@RickiNano RickiNano deleted the clean-up-includes branch January 13, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants