Disambiguity of all the implemented locks by thsfs · Pull Request #4045 · nanocurrency/nano-node

thsfs · 2023-01-13T16:52:16Z

Found a warning when building the node for Windows.

...
warning C4930: 'std::unique_lock<nano::mutex> lock(nano::mutex)': prototyped function not called (was a variable definition intended?)
...

This is related to an ambiguity described by the wiki, where the C++ compiler tries to declare a function as lock instead of creating an object for it.

The best approach is to use the uniform initialization {} when there is any argument. The warning was issued only for vote_processor.cpp, but decided to change all the mutex lock object creations.

dsiganos · 2023-01-13T17:42:48Z

I find it annoying that our formatter treat {} differently from ().
It remove a space before { and adds spaces inside the brackets.

-                       nano::lock_guard<nano::mutex> lk (connections_mutex);
+                       nano::lock_guard<nano::mutex> lk{ connections_mutex };

thsfs · 2023-01-13T17:44:07Z

I find it annoying that our formatter treat {} differently from (). It remove a space before { and adds spaces inside the brackets.
-                       nano::lock_guard<nano::mutex> lk (connections_mutex);
+                       nano::lock_guard<nano::mutex> lk{ connections_mutex };

Yes, but in another perspective it is easier to spot the difference.

Thiago Silva added 30 commits January 13, 2023 10:48

Apply uniform initialization to the mutexes (vote_processor.cpp)

2e1083a

Apply uniform initialization to the mutexes (blockprocessor.cpp)

0b9e0bc

Apply uniform initialization to the mutexes (voting.cpp)

7cdf7bc

Apply uniform initialization to the mutexes (active_transaction.cpp)

577104f

Apply uniform initialization to the mutexes (network.cpp)

3041f99

Apply uniform initialization to the mutexes (election.cpp)

ad35ee2

Apply uniform initialization to the mutexes (tcp.cpp)

415f1f9

Apply uniform initialization to the mutexes (udp.cpp)

1aa5db1

Apply uniform initialization to the mutexes (bootstrap_legacy.cpp)

d84f85b

Apply uniform initialization to the mutexes (bootstrap.cpp)

1cbda88

Apply uniform initialization to the mutexes (boostrap_lazy.cpp)

2bf5d58

Apply uniform initialization to the mutexes (bootstrap_connections.cpp)

a1b2d9a

Apply uniform initialization to the mutexes (online_reps.cpp)

3312406

Apply uniform initialization to the mutexes (ipc)

1e386f9

Apply uniform initialization to the mutexes (repcrawler.cpp)

529ac04

Apply uniform initialization to the mutexes (node.cpp)

7bcb947

Apply uniform initialization to the mutexes (request_aggregator.cpp)

089060f

Apply uniform initialization to the mutexes (gap_cache.cpp)

df94aaf

Apply uniform initialization to the mutexes (ledger.cpp)

b8ba731

Apply uniform initialization to the mutexes (node.cpp)

aaa1fe9

Apply uniform initialization to the mutexes (locks.cpp)

965cc5c

Apply uniform initialization to the mutexes (utility.cpp)

99c6d7f

Apply uniform initialization to the mutexes (blocks.cpp)

d42be64

Apply uniform initialization to the mutexes (observer_set.hpp)

ef780db

Apply uniform initialization to the mutexes (stats.cpp)

cec9fd4

Apply uniform initialization to the mutexes (work.cpp)

fcedbc4

Apply uniform initialization to the mutexes (entry.cpp)

27d6914

Apply uniform initialization to the mutexes (block_arrival.cpp)

4adadb8

Apply uniform initialization to the mutexes (bootstrap_attempt.cpp)

0c28927

Apply uniform initialization to the mutexes (cli.cpp)

b612607

Thiago Silva added 10 commits January 13, 2023 13:35

Apply uniform initialization to the mutexes (distributed_work.cpp)

dd01692

Apply uniform initialization to the mutexes (gap_cache.cpp)

35785f5

Apply uniform initialization to the mutexes (openclwork.cpp)

87b1ce5

Apply uniform initialization to the mutexes (node.cpp)

bf5b98d

Apply uniform initialization to the mutexes (tcp_server.cpp)

a334699

Apply uniform initialization to the mutexes (wallet.cpp)

f06fc36

Apply uniform initialization to the mutexes (rpc_request_processor.cpp)

0b7bee5

Apply uniform initialization to the mutexes (common.cpp)

3c01ba9

Apply uniform initialization to the mutexes (network_filter.cpp)

d58a762

Apply uniform initialization to the mutexes (testutil.hpp)

f692af8

thsfs requested a review from clemahieu January 13, 2023 16:52

thsfs modified the milestones: V24.0, V25.0 Jan 13, 2023

clemahieu approved these changes Jan 13, 2023

View reviewed changes

thsfs merged commit 7a052d4 into nanocurrency:develop Jan 13, 2023

thsfs deleted the object-creation-funcion-declaration-ambiguity-fix branch January 13, 2023 18:02

thsfs added enhancement build-error and removed enhancement labels Mar 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disambiguity of all the implemented locks#4045

Disambiguity of all the implemented locks#4045
thsfs merged 40 commits intonanocurrency:developfrom
thsfs:object-creation-funcion-declaration-ambiguity-fix

thsfs commented Jan 13, 2023

Uh oh!

dsiganos commented Jan 13, 2023

Uh oh!

thsfs commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

thsfs commented Jan 13, 2023

Uh oh!

dsiganos commented Jan 13, 2023

Uh oh!

thsfs commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants