Adding boost as a submodule rather than depending on external references.#4030
Merged
clemahieu merged 2 commits intonanocurrency:developfrom Jan 13, 2023
Merged
Adding boost as a submodule rather than depending on external references.#4030clemahieu merged 2 commits intonanocurrency:developfrom
clemahieu merged 2 commits intonanocurrency:developfrom
Conversation
Contributor
Author
|
Related to #4024 |
Contributor
Author
|
Disk usage stats: nano-node repo without boost submodule initialised Size of full boost repo: Boost source extracted from archive: With boost_checkout_lite.sh With full recursive checkout |
e726b07 to
c719684
Compare
62d1336 to
ad9a6a9
Compare
pwojcikdev
requested changes
Jan 12, 2023
dsiganos
reviewed
Jan 12, 2023
3aa8aa3 to
cd05c50
Compare
cb96ae0 to
cca9b7d
Compare
pwojcikdev
previously approved these changes
Jan 13, 2023
Contributor
pwojcikdev
left a comment
There was a problem hiding this comment.
It's good to see the conversion removed a lot of unnecessary complexity from cmakefiles and source
cc8015f to
e96775b
Compare
…xternally. The boost libs are now statically linked to the nano targets so dynamic linking related functionality has been removed. Adding several target link references that were missing but not apparent when using the unified boost install directories Linking to boost stacktrace basic as this is the main functionality we use. Windows Event Log support has been disabled as there is a compatibility issue with GitHub builders Windows cryptopp ASM has been disabled since CMake isn't assembling .asm files for unknown reasons. Added boost_checkout_lite.sh script which can be used to do a minimal clone of the boost submodule after it's been added but not yet initialized.
e96775b to
9b2d4a6
Compare
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to boost 1.81 and removing CMake target links to Boost::boost which are no longer needed
Added boost_checkout_lite.sh which can be used to only clone required dependencies rather than every boost submodule in the /libs folder. The boost submodule can be initialized with: git submodule update --init boost && ./boost_checkout_lite.sh