Remove UDP support from the peer_container tests#3923
Merged
Conversation
Contributor
Author
|
Marked as draft until fixing two remaining tests:
|
bbb8160 to
a249a97
Compare
a249a97 to
c11dfba
Compare
dsiganos
reviewed
Feb 7, 2023
dsiganos
reviewed
Feb 8, 2023
dsiganos
reviewed
Feb 8, 2023
added 6 commits
February 8, 2023 11:03
This test was originally written for UDP. For TCP "no recontacting" is not an expected behavior. This test may pass, there will be the disconnection but few seconds after there might be a new connection.
c11dfba to
7291347
Compare
dsiganos
reviewed
Feb 8, 2023
dsiganos
previously approved these changes
Feb 8, 2023
dsiganos
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate peer_container tests that use UDP to TCP.
Fixes issue: #3846