Skip to content

V23.1 Cumulative patch#3828

Merged
clemahieu merged 7 commits intonanocurrency:releases/v23from
clemahieu:v23.1
May 19, 2022
Merged

V23.1 Cumulative patch#3828
clemahieu merged 7 commits intonanocurrency:releases/v23from
clemahieu:v23.1

Conversation

@clemahieu
Copy link
Copy Markdown
Contributor

No description provided.

clemahieu and others added 7 commits April 11, 2022 18:42
… reached. This prevents the unchecked table size from increasing beyond reasonable bounds when it's in sync.
* Node ID persistence

After this change, node IDs will persist on the disk file system and
reused. The node ID will not be changing after every restart.
This will help to more reliably track PRs.

The node can be forced to generate a new ID by deleting the file:
node_id_private.key

Note that this change does not prevent the man in the middle attack.

However, it makes it possible to detect telemetry spoofing. Sites like
nanolooker and nanoticker can maintain associations between node ID and PR
and only accept a telemetry packet, if the telemetry message is signed
by the known Node ID.

Co-authored-by: clemahieu <clemahieu@gmail.com>
# Conflicts:
#	nano/core_test/node.cpp
@thsfs thsfs added this to the V23.1 milestone May 19, 2022
@zhyatt zhyatt requested review from dsiganos, theohax, thsfs and zhyatt May 19, 2022 16:26
@dsiganos
Copy link
Copy Markdown
Contributor

dsiganos commented May 19, 2022

I think we shuld set the version number to be .99 since this will effectively be the development branch of v23.
Then we set it to v23.1.0.0 when we actually do the release branch and tag.

@zhyatt zhyatt added the bug label May 19, 2022
@clemahieu clemahieu merged commit 53c2e9b into nanocurrency:releases/v23 May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants