Skip to content

Limit the publishing of public builds and Docker images to only the public repository#3822

Merged
thsfs merged 11 commits intonanocurrency:developfrom
zhyatt:limit-workflow-publish
May 27, 2022
Merged

Limit the publishing of public builds and Docker images to only the public repository#3822
thsfs merged 11 commits intonanocurrency:developfrom
zhyatt:limit-workflow-publish

Conversation

@zhyatt
Copy link
Copy Markdown
Collaborator

@zhyatt zhyatt commented May 17, 2022

  • Update ci/actions/windows/deploy.ps1 to perform same limits on Windows builds

By setting a GitHub Secret of S3_BUILD_DIRECTORY with a name, builds done on repositories other than nanocurrency/nano-node can be pushed to an alternate build directory within S3.

When running in repositories other than nanocurrency/nano-node, the publish to Docker Hub will be blocked, but publishing to GitHub Container Registry (ghcr.io) to (default) private registries will still be done.

@zhyatt zhyatt requested a review from thsfs May 17, 2022 17:07
thsfs
thsfs previously approved these changes May 17, 2022
@thsfs
Copy link
Copy Markdown
Contributor

thsfs commented May 17, 2022

Looks good.

@zhyatt zhyatt requested a review from thsfs May 17, 2022 21:19
thsfs
thsfs previously approved these changes May 18, 2022
@zhyatt zhyatt marked this pull request as ready for review May 21, 2022 02:13
@zhyatt zhyatt requested a review from thsfs May 21, 2022 02:15
@thsfs thsfs merged commit 3e2b49e into nanocurrency:develop May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants