Merged
Conversation
…abstraction hole.
…g abstraction hole.
…ving abstraction hole.
…oving abstraction hole.
…lass removing abstraction hole.
…ing abstraction hole.
…ng abstraction hole.
…moving abstraction hole.
…ing abstraction hole.
…ss removing abstraction hole.
… class removing abstraction hole.
…removing abstraction hole.
dsiganos
reviewed
May 5, 2022
| class bulk_pull_account_client final : public std::enable_shared_from_this<nano::bulk_pull_account_client> | ||
| { | ||
| public: | ||
| bulk_pull_account_client (std::shared_ptr<nano::bootstrap_client> const &, std::shared_ptr<nano::bootstrap_attempt> const &, nano::account const &); |
Contributor
There was a problem hiding this comment.
I may be misunderstanding this but it seems strange to me to limit the bulk pull to a wallet bootstrap attempt only.
Contributor
Author
There was a problem hiding this comment.
This is a bulk_pull_account call which is a different network messages from bulk_pull. It is only used by bootstrap_attempt_wallet.
thsfs
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a number of abstraction holes on nano::bootstrap_attempt that expose implementation details of concrete subtypes.