Skip to content

Changes the accounts_representatives RPC to return per account response#3789

Merged
thsfs merged 2 commits intodevelopfrom
accounts_representatives_per_item_response
Apr 14, 2022
Merged

Changes the accounts_representatives RPC to return per account response#3789
thsfs merged 2 commits intodevelopfrom
accounts_representatives_per_item_response

Conversation

@thsfs
Copy link
Copy Markdown
Contributor

@thsfs thsfs commented Apr 13, 2022 •
edited
Loading

The previous implementation returned only an error result in case any of the provided accounts were invalid or not found. This implementation handles each account separately returning either a successful or an error response.

Example:

    "representatives": {
        "nano_3wfddg7a1paogrcwi3yhwnaerboukbr7rs3z3ino5toyq3yyhimo6f6egij6": "nano_3wfddg7a1paogrcwi3yhwnaerboukbr7rs3z3ino5toyq3yyhimo6f6egij6",
        "nano_36uccgpjzhjsdbj44wm1y5hyz8gefx3wjpp1jircxt84nopxkxti5bzq1rnz": "error: Bad account number",
        "nano_1hrts7hcoozxccnffoq9hqhngnn9jz783usapejm57ejtqcyz9dpso1bibuy": "error: Account not found"
    }

Reference issue: #3752

@thsfs thsfs requested a review from zhyatt April 13, 2022 01:39
dsiganos
dsiganos reviewed Apr 13, 2022
View reviewed changes
@thsfs thsfs added the rpc Changes related to Remote Procedure Calls label Apr 13, 2022
@thsfs thsfs added this to the V24.0 milestone Apr 13, 2022
@thsfs thsfs force-pushed the accounts_representatives_per_item_response branch from 8cb7a8d to 0e235a9 Compare April 13, 2022 14:39
@thsfs thsfs requested a review from clemahieu April 13, 2022 16:54
@zhyatt zhyatt mentioned this pull request Apr 14, 2022
Merged
@nanocurrency nanocurrency deleted a comment from clemahieu Apr 14, 2022
@thsfs thsfs force-pushed the accounts_representatives_per_item_response branch from 0e235a9 to f86622f Compare April 14, 2022 18:08
@thsfs thsfs requested a review from dsiganos April 14, 2022 18:09
@thsfs thsfs merged commit ba83c03 into develop Apr 14, 2022
@thsfs thsfs deleted the accounts_representatives_per_item_response branch April 14, 2022 19:19
@thsfs thsfs assigned thsfs and unassigned thsfs Jan 19, 2023
@thsfs thsfs added the documentation This item indicates the need for or supplies updated or expanded documentation label Jan 19, 2023
@thsfs thsfs mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsiganos dsiganos dsiganos approved these changes

@zhyatt zhyatt Awaiting requested review from zhyatt

@clemahieu clemahieu Awaiting requested review from clemahieu

Assignees

No one assigned

Labels

documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls

Projects

None yet

Milestone

V24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thsfs @dsiganos