Pending to receivable renames#3753
Merged
dsiganos merged 10 commits intonanocurrency:developfrom Mar 28, 2022
Merged
Conversation
…e reply Introduce new option called receivable to replace pending option. Currently both are supported and do the same job. However, if both are set, receivable has priority. Also added confirmed_receivable reply when include_confirmed is set.
Pending is still supported but deprecated
The ledger RPC command only supported pending option. Now, it supports both with receivable having priority, if both are set.
The RPC commands did not return "deprecated=true", now they do. Also renamed underlying handling functions from pending to receivable.
theohax
approved these changes
Mar 28, 2022
Contributor
theohax
left a comment
There was a problem hiding this comment.
There's probably quite a bunch of pendings left, but this definitely looks good towards our new terminology and hopefully will make things less confusing (Y)
clemahieu
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deprecated field in RPC response of pending and pending_exists
The RPC commands did not return "deprecated=true", now they do.
Also renamed underlying handling functions from pending to receivable.
Add support for receivable option to wallet_ledger RPC
Add support for receivable option to ledger RPC command
The ledger RPC command only supported pending option.
Now, it supports both with receivable having priority, if both are set.
Convert RPC blocks_info to use receivable rather than pending
Rename
nano::ledger::account_pendingtonano::ledger::account_receivableaccount_info rpc: introduce receivable option and confirmed_receivable reply
Introduce new option called receivable to replace pending option.
Currently both are supported and do the same job.
However, if both are set, receivable has priority.
Also added confirmed_receivable reply when include_confirmed is set.
Copy search_pending to search_receivable and deprecate the former
Copy search_pending_all to search_receivable_all and deprecate the former
Copy wallet_pending to wallet_receivable and deprecate the former
Copy accounts_pending to accounts_receivable and deprecate the former
resolves #3689