Fix unchecked_map destructor.#3723
Merged
clemahieu merged 1 commit intonanocurrency:developfrom Feb 8, 2022
Merged
Conversation
Contributor
|
In practice I doubt this can actually bite us, but yeah, the proper way of announcing changes via CVs is under the mutex indeed, even if the change is atomic like this one. Just curious, have you seen this cause issues? |
theohax
previously approved these changes
Feb 8, 2022
dsiganos
reviewed
Feb 8, 2022
Contributor
|
@theohax In practice, it would bite us on node shutdown, the node could deadlock on shutdown. |
Contributor
Author
|
If the working thread is between these two lines when stopped is set to true and the condition variable in notified, it will neither detect the stopped flag nor detect the condition variable notification. |
0a367c3 to
fe9e60d
Compare
dsiganos
previously approved these changes
Feb 8, 2022
thsfs
previously approved these changes
Feb 8, 2022
…ariable signal can be missed since the object mutex isn't acquired while setting stopped=true. Converts unchecked_map::stopped to a non-atomic bool since it needs a mutex anyway.
fe9e60d to
d0089a3
Compare
thsfs
approved these changes
Feb 8, 2022
thsfs
reviewed
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with unchecked_map::~unchecked_map where the condition variable signal can be missed since the object mutex isn't acquired while setting stopped=true.